[Android] Implement min/max on all supported date types

content/public/android/java/src/org/chromium/content/browser/input/DateDialogNormalizer.java

Index: content/public/android/java/src/org/chromium/content/browser/input/DateDialogNormalizer.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/DateDialogNormalizer.java b/content/public/android/java/src/org/chromium/content/browser/input/DateDialogNormalizer.java
new file mode 100644
index 0000000000000000000000000000000000000000..3395ca5ed6c7e71a1b7d11c9f27e7936b8cfcecf
--- /dev/null
+++ b/content/public/android/java/src/org/chromium/content/browser/input/DateDialogNormalizer.java
@@ -0,0 +1,48 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.

[bulach, 2013/05/21 17:26:35]

nit: add a \n

[Miguel Garcia, 2013/05/23 12:16:48]

Done.

+package org.chromium.content.browser.input;
+
+import android.widget.DatePicker;
+import android.widget.DatePicker.OnDateChangedListener;
+
+import java.util.Calendar;
+
+/**
+ * Normalize a date dialog so that it respect min and max.
+ */
+public class DateDialogNormalizer {

[bulach, 2013/05/21 17:26:35]

nit: it looks like it can be package-private, ditto for the methods

[Miguel Garcia, 2013/05/23 12:16:48]

Done.

+    static long ONE_DAY_MILLIS = 3600 * 24 * 1000;

[bulach, 2013/05/21 17:26:35]

nit: final, and also I think it'd be clearer in hours * minutes * seconds *
millis, i.e., 24 * 60 * 60 * 1000;

[Miguel Garcia, 2013/05/23 12:16:48]

Done.

+
+    private static void setLimits(DatePicker picker, long min, long max) {
+        // DatePicker intervals are non inclusive
+        long minTime = min > 0 ? min -1 : 0;

[bulach, 2013/05/21 17:26:35]

nit: space after -

[Miguel Garcia, 2013/05/23 12:16:48]

Done.

+        long maxTime = (max - ONE_DAY_MILLIS) >= (Long.MAX_VALUE - ONE_DAY_MILLIS)
+                ? Long.MAX_VALUE : max + ONE_DAY_MILLIS;
+        picker.setMaxDate(maxTime);
+        picker.setMinDate(minTime);
+    }
+
+    /**
+     * Create a verified DateDialogPicker

[bulach, 2013/05/21 17:26:35]

I don't think it "creates" a dialog, but rather, ensures DateDialogPicker is
within the boundaries.

[Miguel Garcia, 2013/05/23 12:16:48]

Done.

+     */
+    public static void normalize(DatePicker picker, OnDateChangedListener callBack,

[bulach, 2013/05/21 17:26:35]

nit: s/callBack/listener/

[Miguel Garcia, 2013/05/23 12:16:48]

Done.

+            int year, int month, int day, long min, long max) {
+        Calendar calendar = Calendar.getInstance();
+        calendar.clear();
+        calendar.set(year, month, day);
+        if (calendar.getTimeInMillis() < min) {
+            calendar.clear();
+            calendar.setTimeInMillis(min);
+        } else if (calendar.getTimeInMillis() > max) {
+            calendar.clear();
+            calendar.setTimeInMillis(max);
+        }
+        picker.init(
+                calendar.get(Calendar.YEAR), calendar.get(Calendar.MONTH),
+                calendar.get(Calendar.DAY_OF_MONTH), callBack);
+
+        // DatePicker intervals are non inclusive
+        setLimits(picker, min, max);
+    }
+}