Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: content/renderer/renderer_date_time_picker.cc

Issue 15533003: [Android] Implement min/max on all supported date types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased to pick up the simplifications of the month picker Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/renderer_date_time_picker.cc
diff --git a/content/renderer/renderer_date_time_picker.cc b/content/renderer/renderer_date_time_picker.cc
index f17ba3588be5d0001e42c594fbfdbd7875815389..5bc4e2a35d8947c25abf93d10b1dad777b639575 100644
--- a/content/renderer/renderer_date_time_picker.cc
+++ b/content/renderer/renderer_date_time_picker.cc
@@ -31,8 +31,6 @@ RendererDateTimePicker::~RendererDateTimePicker() {
bool RendererDateTimePicker::Open() {
DateTimeFormatter parser(chooser_params_);
- std::string test_s = chooser_params_.currentValue.utf8();
-
ViewHostMsg_DateTimeDialogValue_Params message;
message.year = parser.GetYear();
message.month = parser.GetMonth();
@@ -41,7 +39,10 @@ bool RendererDateTimePicker::Open() {
message.minute = parser.GetMinute();
message.second = parser.GetSecond();
message.dialog_type = parser.GetType();
-
+ if (chooser_params_.minimum > 0)
bulach 2013/05/30 14:16:30 iirc, the ViewHostMsg_DateTimeDialogValue_Params m
Miguel Garcia 2013/06/03 13:08:58 Good point, let's better be safe than sorry here.
+ message.minimum = chooser_params_.minimum;
+ if (chooser_params_.maximum > 0)
+ message.maximum = chooser_params_.maximum;
Send(new ViewHostMsg_OpenDateTimeDialog(routing_id(), message));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698