Tighten up gn check.

Tighten up gn check.

Notably outstanding are //gpu, //sandbox, and //tonic. Once those are
fixed, this whole list could be removed.

TESTED=gn check out/Debug && gn check out/android_Debug
BUG=
R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/c6d1434a8b4a06e58b427caacbba7883b0796ea4

[tonyg, 2016-01-04 23:16:42]

Description was changed from

==========
Tighten up gn check.

Notably outstanding are //gpu, //sandbox, and //tonic. Once those are
fixed, this whole list could be removed.

TESTED=gn check out/Debug && gn check out/android_Debug
BUG=
==========

to

==========
Tighten up gn check.

Notably outstanding are //gpu, //sandbox, and //tonic. Once those are
fixed, this whole list could be removed.

TESTED=gn check out/Debug && gn check out/android_Debug
BUG=
==========

[tonyg, 2016-01-04 23:16:42]

tonyg@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2016-01-04 23:19:44]

https://codereview.chromium.org/1553293002/diff/1/.gn
File .gn (right):

https://codereview.chromium.org/1553293002/diff/1/.gn#newcode28
.gn:28: "//navtive_client/*",
looks like a typo, did you mean native_client ? could you confirm that label is
clean too?

[tonyg, 2016-01-04 23:22:36]

https://codereview.chromium.org/1553293002/diff/1/.gn
File .gn (right):

https://codereview.chromium.org/1553293002/diff/1/.gn#newcode28
.gn:28: "//navtive_client/*",
On 2016/01/04 23:19:44, jamesr wrote:
> looks like a typo, did you mean native_client ? could you confirm that label
is
> clean too?

Oops. Good catch. Fixed and verified it is clean.

/me wishes gn check failed if any of these patterns matched 0 targets.

[jamesr, 2016-01-04 23:23:14]

Cool, lgtm.

[tonyg, 2016-01-04 23:24:21]

Description was changed from

==========
Tighten up gn check.

Notably outstanding are //gpu, //sandbox, and //tonic. Once those are
fixed, this whole list could be removed.

TESTED=gn check out/Debug && gn check out/android_Debug
BUG=
==========

to

==========
Tighten up gn check.

Notably outstanding are //gpu, //sandbox, and //tonic. Once those are
fixed, this whole list could be removed.

TESTED=gn check out/Debug && gn check out/android_Debug
BUG=
R=jamesr@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/c6d1434a8b4a06e58b427caacbb...
==========

[tonyg, 2016-01-04 23:24:29]

Committed patchset #2 (id:20001) manually as
c6d1434a8b4a06e58b427caacbba7883b0796ea4 (presubmit successful).