Remove Pass on CrOS.

Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org,spang@chromium.org
TBR=reveman@chromium.org,sky@chromium.org

Committed: https://crrev.com/78820a435f2d94fb08e9a4cdb810b811c6cbdea9
Cr-Commit-Position: refs/heads/master@{#368009}

[dcheng, 2016-01-04 22:37:24]

Worked on my machine. Let's ship it!

[dcheng, 2016-01-04 22:39:59]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 22:40:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553263002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553263002/1

[danakj, 2016-01-04 22:43:12]

LGTM

[commit-bot: I haz the power, 2016-01-04 23:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 23:12:18]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[dcheng, 2016-01-04 23:40:41]

dcheng@chromium.org changed reviewers:
+ sandersd@chromium.org

[dcheng, 2016-01-04 23:40:42]

TBRing sandersd@ for //content/common/gpu/media changes (which are behind a
GN/GYP flag)

[dcheng, 2016-01-04 23:40:51]

Description was changed from

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org
==========

to

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org
TBR=sandersd@chromium.org
==========

[dcheng, 2016-01-04 23:40:52]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-01-04 23:40:53]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1553263002/#ps20001
(title: "Also include a change that lives behind a gyp define")

[danakj, 2016-01-04 23:41:08]

LGTM

[commit-bot: I haz the power, 2016-01-04 23:42:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553263002/20001

[sandersd (OOO until July 31), 2016-01-04 23:45:26]

lgtm

[commit-bot: I haz the power, 2016-01-05 00:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 00:36:36]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[dcheng, 2016-01-05 01:09:10]

Description was changed from

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org
TBR=sandersd@chromium.org
==========

to

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org
TBR=spang@chromium.org
==========

[dcheng, 2016-01-05 01:09:10]

dcheng@chromium.org changed reviewers:
+ spang@chromium.org

[dcheng, 2016-01-05 01:09:20]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-01-05 01:09:21]

Annnnd TBRing spang@ for //ui/events/ozone/evdev changes too.

[dcheng, 2016-01-05 01:09:21]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/1553263002/#ps40001
(title: "Blind fixes in //ui")

[commit-bot: I haz the power, 2016-01-05 01:09:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553263002/40001

[commit-bot: I haz the power, 2016-01-05 01:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 01:51:11]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-01-05 01:57:18]

dcheng@chromium.org changed reviewers:
+ sky@chromium.org

[dcheng, 2016-01-05 01:57:25]

TBRing sky as well for //ash

[dcheng, 2016-01-05 01:57:37]

Description was changed from

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org
TBR=spang@chromium.org
==========

to

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org
TBR=sky@chromium.org,spang@chromium.org
==========

[dcheng, 2016-01-05 01:57:39]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-01-05 01:57:39]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/1553263002/#ps60001
(title: "Ozone fixes in //ash")

[commit-bot: I haz the power, 2016-01-05 01:57:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553263002/60001

[commit-bot: I haz the power, 2016-01-05 02:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 02:35:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[spang, 2016-01-05 18:47:57]

Description was changed from

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org
TBR=sky@chromium.org,spang@chromium.org
==========

to

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org
TBR=sky@chromium.org
==========

[spang, 2016-01-05 18:48:06]

lgtm

[spang, 2016-01-05 18:48:19]

On 2016/01/05 18:48:06, spang wrote:
> lgtm

% build failures of course

[dcheng, 2016-01-07 01:29:45]

Description was changed from

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org
TBR=sky@chromium.org
==========

to

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org,spang@chromium.org
TBR=reveman@chromium.org,sky@chromium.org
==========

[dcheng, 2016-01-07 01:29:45]

dcheng@chromium.org changed reviewers:
+ reveman@chromium.org

[dcheng, 2016-01-07 01:30:36]

dcheng@chromium.org changed reviewers:
+ spang@chromium.orgok
- reveman@chromium.org, spang@chromium.org

[dcheng, 2016-01-07 01:30:36]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-01-07 01:30:37]

OK, there are far too many feature-specific defines/flags on the CroS bots...

Fixed //components/exo and trying again (I ran the tool across a CrOS ozone
build to try to see if there was anything else major I'm missing, and that seems
to be it). So fingers crossed and TBRing reveman@ for //components/exo changes.

[dcheng, 2016-01-07 01:30:37]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
sandersd@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/1553263002/#ps100001
(title: "Fix //components/exo too")

[commit-bot: I haz the power, 2016-01-07 01:32:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553263002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553263002/100001

[commit-bot: I haz the power, 2016-01-07 03:55:03]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-07 03:56:01]

Description was changed from

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org,spang@chromium.org
TBR=reveman@chromium.org,sky@chromium.org
==========

to

==========
Remove Pass on CrOS.

Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>.

BUG=557422
R=danakj@chromium.org,sandersd@chromium.org,spang@chromium.org
TBR=reveman@chromium.org,sky@chromium.org

Committed: https://crrev.com/78820a435f2d94fb08e9a4cdb810b811c6cbdea9
Cr-Commit-Position: refs/heads/master@{#368009}
==========

[commit-bot: I haz the power, 2016-01-07 03:56:01]

Patchset 6 (id:??) landed as
https://crrev.com/78820a435f2d94fb08e9a4cdb810b811c6cbdea9
Cr-Commit-Position: refs/heads/master@{#368009}