Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1553233006: Add debug sentinel to GrMemoryPool to check for memory stomping (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M src/gpu/GrMemoryPool.h View 1 chunk +11 lines, -1 line 0 comments Download
M src/gpu/GrMemoryPool.cpp View 4 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
robertphillips
Unfortunately this didn't find anything on Linux.
4 years, 11 months ago (2016-01-05 22:03:34 UTC) #5
joshualitt
On 2016/01/05 22:03:34, robertphillips wrote: > Unfortunately this didn't find anything on Linux. lgtm
4 years, 11 months ago (2016-01-06 14:11:11 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553233006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553233006/1
4 years, 11 months ago (2016-01-06 14:47:24 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 15:02:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553233006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553233006/1
4 years, 11 months ago (2016-01-06 15:04:18 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 15:04:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19c6250cad89d0e06a737919da94d6bc5c85cb1a

Powered by Google App Engine
This is Rietveld 408576698