Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1553233003: Guard UnmapFreeMemoryTask with a flag. (Closed)

Created:
4 years, 11 months ago by ulan
Modified:
4 years, 11 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Guard UnmapFreeMemoryTask with a flag. BUG=chromium:574349 LOG=NO Committed: https://crrev.com/a373e7530c67c964146555c37ad07b5f73737272 Cr-Commit-Position: refs/heads/master@{#33113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/heap/heap.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
ulan
PTAL
4 years, 11 months ago (2016-01-05 10:28:47 UTC) #2
Michael Lippautz
lgtm
4 years, 11 months ago (2016-01-05 10:44:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553233003/1
4 years, 11 months ago (2016-01-05 10:47:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9437)
4 years, 11 months ago (2016-01-05 11:34:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553233003/1
4 years, 11 months ago (2016-01-05 11:37:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-05 12:47:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553233003/1
4 years, 11 months ago (2016-01-05 13:08:00 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 13:10:59 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 13:11:27 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a373e7530c67c964146555c37ad07b5f73737272
Cr-Commit-Position: refs/heads/master@{#33113}

Powered by Google App Engine
This is Rietveld 408576698