Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1553193002: Roll NSS by one revision (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll NSS by one revision Picks up https://codereview.chromium.org/1558903002/ and syncs the warning flags in NSS's BUILD.gn with the gyp file. BUG=573779 Committed: https://crrev.com/be09deaee48ac4e4dc274c04da6ecddc032bd2f5 Cr-Commit-Position: refs/heads/master@{#367337}

Patch Set 1 #

Patch Set 2 : how do i git #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Nico
Thanks for that code review! As a token of my appreciation, here's a code review. ...
4 years, 11 months ago (2016-01-04 17:46:23 UTC) #2
Mark Mentovai
LGTM Nico wrote: > Thanks for that code review! As a token of my appreciation, ...
4 years, 11 months ago (2016-01-04 17:48:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553193002/20001
4 years, 11 months ago (2016-01-04 17:49:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 19:06:19 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 19:07:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be09deaee48ac4e4dc274c04da6ecddc032bd2f5
Cr-Commit-Position: refs/heads/master@{#367337}

Powered by Google App Engine
This is Rietveld 408576698