tools/telemetry/telemetry/web_perf/metrics/memory_timeline_unittest.py - Issue 1553183002: [telemetry] Add support for composable process dumps in memory-infra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/memory_timeline_unittest.py

Issue 1553183002: [telemetry] Add support for composable process dumps in memory-infra (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py ('K') | « tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/metrics/memory_timeline_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/memory_timeline_unittest.py b/tools/telemetry/telemetry/web_perf/metrics/memory_timeline_unittest.py

index 001b05fec7c55e40463b15fcd39bfacbffb50140..6a681b7584980dfc1ca95ffe2a9d5b0ad335baf2 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/memory_timeline_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/memory_timeline_unittest.py

@@ -18,6 +18,7 @@ def MockProcessDumpEvent(dump_id, name, start, memory_usage):

process_dump.dump_id = dump_id

process_dump.process_name = name

process_dump.start = start

+ process_dump.end = start

if memory_usage is None:

memory_usage = {}

elif not isinstance(memory_usage, dict):