Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1553143002: PPC: Use register arguments for RestParamAccessStub (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Use register arguments for RestParamAccessStub Port 82ca2a414deb4221100562a0fb2af0f216c4c3ef Original commit message: This is preferable because in TurboFan we need to call it, and can't pass untagged external pointers on the stack. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/f5036a7641dcd4d83ba6587426ce11510b5cb265 Cr-Commit-Position: refs/heads/master@{#33092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553143002/1
4 years, 11 months ago (2016-01-04 15:57:38 UTC) #2
MTBrandyberry
4 years, 11 months ago (2016-01-04 15:59:08 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 16:26:25 UTC) #5
JoranSiu
On 2016/01/04 16:26:25, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2016-01-04 18:32:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553143002/1
4 years, 11 months ago (2016-01-04 18:38:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 18:39:48 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 18:40:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5036a7641dcd4d83ba6587426ce11510b5cb265
Cr-Commit-Position: refs/heads/master@{#33092}

Powered by Google App Engine
This is Rietveld 408576698