Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1553133002: Revert "Reland: Make ScrollbarThemeAura selectively invalidate scrollbar parts." (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 11 months ago
Reviewers:
skobes, ccameron
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kinuko+watch, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Reland: Make ScrollbarThemeAura selectively invalidate scrollbar parts." This reverts commit 54342454be5d73c64aa47b57facd880ba8df2b36. Caused a Mac 10.10 perf regression, and possibly at fault for scrollbar invalidation issues. BUG=573266, 549277 TBR=skobes@chromium.org,ccameron@chromium.org Committed: https://crrev.com/dc84889161c48bd2224893c3749d1994a2373e3d Cr-Commit-Position: refs/heads/master@{#367331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -270 lines) Patch
M third_party/WebKit/LayoutTests/fast/repaint/overflow-move-after-scroll-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-after-move-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/invalidate-after-composited-scroll-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 6 chunks +3 lines, -111 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 5 chunks +6 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 5 chunks +23 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp View 3 chunks +41 lines, -100 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jbroman
perf tryjob confirms that reverting fixes the 10.10 regression reported by the bots (https://codereview.chromium.org/1552763003); will ...
4 years, 11 months ago (2016-01-04 16:28:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553133002/1
4 years, 11 months ago (2016-01-04 16:29:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 18:48:04 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 18:49:11 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc84889161c48bd2224893c3749d1994a2373e3d
Cr-Commit-Position: refs/heads/master@{#367331}

Powered by Google App Engine
This is Rietveld 408576698