Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1553103003: remove 565 effects shaders (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove 565 effects shaders This removes the 565 optimization for radial, linear, sweep, and picture shaders. The optimization gets little real-world use and has a reasonable fallback. This also permits removing the square root table for the radial gradient case. R=reed@google.com BUG=skia:1947 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553103003 Committed: https://skia.googlesource.com/skia/+/0152cc3819291841298013d2b5515a61e974e41f

Patch Set 1 #

Patch Set 2 : remove table #

Patch Set 3 : remove unused functions #

Patch Set 4 : remove more hasspan16 checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -579 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h View 1 chunk +0 lines, -1 line 0 comments Download
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M gyp/effects.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureShader.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 2 3 4 chunks +0 lines, -189 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 3 chunks +0 lines, -173 lines 0 comments Download
D src/effects/gradients/SkRadialGradient_Table.h View 1 1 chunk +0 lines, -139 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553103003/20001
4 years, 11 months ago (2016-01-04 15:13:10 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/5037) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on ...
4 years, 11 months ago (2016-01-04 15:14:17 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553103003/40001
4 years, 11 months ago (2016-01-04 15:23:15 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/4976)
4 years, 11 months ago (2016-01-04 15:32:41 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553103003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553103003/60001
4 years, 11 months ago (2016-01-04 15:59:51 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 16:14:54 UTC) #13
caryclark
4 years, 11 months ago (2016-01-04 17:26:19 UTC) #14
reed1
lgtm
4 years, 11 months ago (2016-01-04 17:38:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553103003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553103003/60001
4 years, 11 months ago (2016-01-04 17:54:21 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 17:54:57 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/0152cc3819291841298013d2b5515a61e974e41f

Powered by Google App Engine
This is Rietveld 408576698