Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1553093004: Reduce memory requirement to linux LTO builds to speed up bots. (Closed)

Created:
4 years, 11 months ago by krasin
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, kcc, pcc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce memory requirement to linux LTO builds to speed up bots. The new requirements won't be enough for the official bots, but the old requirements made all the bots to be extremely slow (5-7 hours), and we don't run official bots as of now, because that was too slow for CFI launch. Reverting to the settings good enough for development, and keep in mind, that we need to do something about the memory consumption for LTO builds before we could attempt to launch again. BUG=570227, 464797 Committed: https://crrev.com/61e70ccb5957620f3329f07ef79a76b81c96044b Cr-Commit-Position: refs/heads/master@{#367323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/toolchain/get_concurrent_links.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
krasin
4 years, 11 months ago (2016-01-04 17:12:32 UTC) #3
krasin
4 years, 11 months ago (2016-01-04 17:17:11 UTC) #4
Nico
lgtm
4 years, 11 months ago (2016-01-04 17:20:48 UTC) #5
krasin
Note: the trybot didn't infer that get_concurrent_links.py is a dependency for all the tests. So, ...
4 years, 11 months ago (2016-01-04 17:29:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553093004/1
4 years, 11 months ago (2016-01-04 17:30:01 UTC) #8
Nico
sgtm; maybe you want to file a bug for analyze not getting this right (if ...
4 years, 11 months ago (2016-01-04 17:32:41 UTC) #9
krasin
Done. https://crbug.com/574119
4 years, 11 months ago (2016-01-04 17:47:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 17:48:40 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 17:49:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61e70ccb5957620f3329f07ef79a76b81c96044b
Cr-Commit-Position: refs/heads/master@{#367323}

Powered by Google App Engine
This is Rietveld 408576698