Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 155309: Chrome-side of fixes for content-script messaging. (Closed)

Created:
11 years, 5 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Chrome-side of fixes for content-script messaging. This change adds registration of content scripts, parented to a frame's context. When a frame's context goes away, we unregister it and any content script contexts for it. There's a corresponding webkit change that lets us know when a content script context is created. Filed upstream as https://bugs.webkit.org/show_bug.cgi?id=27104. BUG=16228 TEST=install an extension with a content script that communicates with a parent process. Messages should be sendable both ways. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20677

Patch Set 1 #

Patch Set 2 : temporary webkit hack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -40 lines) Patch
M chrome/renderer/extensions/bindings_utils.h View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 1 3 chunks +65 lines, -26 lines 0 comments Download
chrome/renderer/render_view.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M webkit/glue/webframeloaderclient_impl.h View 1 chunk +12 lines, -2 lines 0 comments Download
M webkit/glue/webframeloaderclient_impl.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M webkit/glue/webview_delegate.h View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
11 years, 5 months ago (2009-07-09 20:05:25 UTC) #1
Aaron Boodman
11 years, 5 months ago (2009-07-10 01:18:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698