Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1553083005: X87: [Interpreter] Fix some issues in the non-x64 InterpreterNotifyDeoptimized builtins. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Fix some issues in the non-x64 InterpreterNotifyDeoptimized builtins. port 02072112d14d2960fc730fa5cde6b759c47b61a0(r33088) original commit message: Fix stack push issues on non-x64 platforms for InterpreterNotifyDeoptimized builtins. BUG= Committed: https://crrev.com/bdf993698ac90a7053a063e354dd7996671dc469 Cr-Commit-Position: refs/heads/master@{#33103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/builtins-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-05 03:25:11 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-05 03:45:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553083005/1
4 years, 11 months ago (2016-01-05 03:45:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 04:08:47 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 04:09:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdf993698ac90a7053a063e354dd7996671dc469
Cr-Commit-Position: refs/heads/master@{#33103}

Powered by Google App Engine
This is Rietveld 408576698