Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1553083003: Remove wasm compile time option and enable wasm behind a runtime flag. (Closed)

Created:
4 years, 11 months ago by bradn
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove wasm compile time option and enable wasm behind a runtime flag. Deferring enabling of tests to separate per platform CLs. R=machenbach@chromium.org,titzer@chromium.org BUG= Committed: https://crrev.com/0e8b7ec8b1161f2668328b31232321cb231555d0 Cr-Commit-Position: refs/heads/master@{#33123}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -64 lines) Patch
M BUILD.gn View 2 chunks +21 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +0 lines, -6 lines 0 comments Download
M build/features.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +3 lines, -7 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 3 chunks +6 lines, -3 lines 0 comments Download
M test/unittests/unittests.gyp View 2 chunks +4 lines, -8 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +21 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bradnelson
4 years, 11 months ago (2016-01-04 21:40:57 UTC) #2
Michael Achenbach
lgtm from infra/testing p-o-v.
4 years, 11 months ago (2016-01-05 10:11:23 UTC) #3
titzer
On 2016/01/05 10:11:23, Michael Achenbach (OOO) wrote: > lgtm from infra/testing p-o-v. lgtm
4 years, 11 months ago (2016-01-05 10:48:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553083003/40001
4 years, 11 months ago (2016-01-05 18:05:10 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-05 18:06:37 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:07:00 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e8b7ec8b1161f2668328b31232321cb231555d0
Cr-Commit-Position: refs/heads/master@{#33123}

Powered by Google App Engine
This is Rietveld 408576698