Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issue 1553083002: Layout test for 571040. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
dstockwell, shans
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Layout test for 571040. The fix for issue 571040 did not add a test. Here is one. Node::virtualEnsureComputedStyle returns nullptr when there is no parent node (which is strange since the method is called *Ensure*). However, that's what caused the crash. Confirmed that the added test crashes in a pre-christmas checkout. R=shans@chromium.org,dstockwell@chromium.org BUG=571040 Committed: https://crrev.com/1d0e53475a9b3459b1af0e84715b45202ad493a6 Cr-Commit-Position: refs/heads/master@{#367393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/variables/computed-style-detached-node-crash.html View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/variables/computed-style-detached-node-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553083002/1
4 years, 11 months ago (2016-01-04 10:27:45 UTC) #4
rune
ptal
4 years, 11 months ago (2016-01-04 10:28:51 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 11:12:58 UTC) #8
shans
On 2016/01/04 at 10:28:51, rune wrote: > ptal Thanks for this! LGTM
4 years, 11 months ago (2016-01-04 21:33:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553083002/1
4 years, 11 months ago (2016-01-04 22:30:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 22:36:30 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 22:37:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d0e53475a9b3459b1af0e84715b45202ad493a6
Cr-Commit-Position: refs/heads/master@{#367393}

Powered by Google App Engine
This is Rietveld 408576698