Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1553053002: Update pnacl toolchain build (Closed)

Created:
4 years, 11 months ago by Sam Clegg
Modified:
4 years, 11 months ago
Reviewers:
bradnelson
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Update pnacl toolchain build - Don't use pnacl-translate ahead of time - Create regular pkg file - Add very minimal sel_ldr testing Still not working due to wrong main() symbol being linked (link line puts -lppapi ad the beginning rather than the end). Committed: https://chromium.googlesource.com/webports/+/1b1f5899eca3fa8be11c92d64b37aa9d03d7cd47

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -75 lines) Patch
M ports/nacl-spawn/elf_reader.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ports/nacl-spawn/include/nacl_spawn.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ports/nacl-spawn/library_dependencies.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M ports/nacl-spawn/nacl_spawn.cc View 3 chunks +24 lines, -6 lines 0 comments Download
M ports/pkg/nacl.patch View 2 chunks +9 lines, -1 line 0 comments Download
M ports/pnacl-binutils-src/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download
M ports/pnacl-clang-src/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download
M ports/pnacl-llvm-src/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download
M ports/pnacl/build.sh View 1 2 3 5 chunks +21 lines, -51 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Sam Clegg
4 years, 11 months ago (2016-01-12 22:51:24 UTC) #3
bradnelson
lgtm
4 years, 11 months ago (2016-01-12 23:16:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553053002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553053002/80001
4 years, 11 months ago (2016-01-13 18:32:34 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 18:34:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/webports/+/1b1f5899eca3fa8be11c92d64b37aa9d...

Powered by Google App Engine
This is Rietveld 408576698