Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1553043002: [builtins] Migrate a bunch of Object builtins to C++. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate a bunch of Object builtins to C++. The Object.freeze, Object.isExtensible, Object.isFrozen, Object.isSealed, Object.preventExtensions and Object.seal builtins were already implemented in C++, but they still had some funny JavaScript wrappers that just called into the C++ implementation on every (interesting) execution path. Committed: https://crrev.com/70c4bf13315145be89e9f8b7f4313fab2442dcda Cr-Commit-Position: refs/heads/master@{#33074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -155 lines) Patch
M src/bootstrapper.cc View 2 chunks +37 lines, -7 lines 0 comments Download
M src/builtins.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +78 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/array.js View 6 chunks +5 lines, -9 lines 0 comments Download
M src/js/object-observe.js View 6 chunks +6 lines, -10 lines 0 comments Download
M src/js/prologue.js View 2 chunks +3 lines, -1 line 0 comments Download
M src/js/templates.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/v8natives.js View 4 chunks +1 line, -52 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +0 lines, -66 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-405517.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-412319.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
Hey Toon, Reduce useless overhead for C++ builtins on Object. Please take a look. Thanks, ...
4 years, 11 months ago (2016-01-04 05:38:45 UTC) #2
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-04 07:37:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553043002/1
4 years, 11 months ago (2016-01-04 07:47:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 08:10:18 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 08:11:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70c4bf13315145be89e9f8b7f4313fab2442dcda
Cr-Commit-Position: refs/heads/master@{#33074}

Powered by Google App Engine
This is Rietveld 408576698