Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552973002: Convert Pass()→std::move() in //mojo/runner/android (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //mojo/runner/android (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/53612ed4cff4ab91e4f92ee80bb5ad09501a6c09 Cr-Commit-Position: refs/heads/master@{#367244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M mojo/runner/android/android_handler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/runner/android/android_handler_loader.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/runner/android/background_application_loader.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/runner/android/ui_application_loader_android.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
Last Android patch... for real. Hopefully =/
4 years, 11 months ago (2015-12-31 11:01:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552973002/1
4 years, 11 months ago (2015-12-31 11:01:50 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-31 11:18:54 UTC) #5
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-31 14:53:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552973002/1
4 years, 11 months ago (2015-12-31 16:02:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 16:06:25 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 16:07:13 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/53612ed4cff4ab91e4f92ee80bb5ad09501a6c09
Cr-Commit-Position: refs/heads/master@{#367244}

Powered by Google App Engine
This is Rietveld 408576698