Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 15529003: A few simple cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1671 matching lines...) Expand 10 before | Expand all | Expand 10 after
1682 __ CallRuntime(kUpdateFieldCidRuntimeEntry); 1682 __ CallRuntime(kUpdateFieldCidRuntimeEntry);
1683 __ Drop(2); // Drop the field and the value. 1683 __ Drop(2); // Drop the field and the value.
1684 } 1684 }
1685 1685
1686 __ Bind(&ok); 1686 __ Bind(&ok);
1687 } 1687 }
1688 1688
1689 1689
1690 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const { 1690 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const {
1691 const intptr_t kNumInputs = 2; 1691 const intptr_t kNumInputs = 2;
1692 const intptr_t num_temps = 0; 1692 const intptr_t kNumTemps = 0;
1693 LocationSummary* summary = 1693 LocationSummary* summary =
1694 new LocationSummary(kNumInputs, num_temps, LocationSummary::kNoCall); 1694 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
1695 summary->set_in(0, Location::RequiresRegister()); 1695 summary->set_in(0, Location::RequiresRegister());
1696 summary->set_in(1, ShouldEmitStoreBarrier() 1696 summary->set_in(1, ShouldEmitStoreBarrier()
1697 ? Location::WritableRegister() 1697 ? Location::WritableRegister()
1698 : Location::RegisterOrConstant(value())); 1698 : Location::RegisterOrConstant(value()));
1699 return summary; 1699 return summary;
1700 } 1700 }
1701 1701
1702 1702
1703 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1703 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1704 Register instance_reg = locs()->in(0).reg(); 1704 Register instance_reg = locs()->in(0).reg();
(...skipping 2378 matching lines...) Expand 10 before | Expand all | Expand 10 after
4083 __ int3(); 4083 __ int3();
4084 } 4084 }
4085 4085
4086 4086
4087 LocationSummary* GotoInstr::MakeLocationSummary() const { 4087 LocationSummary* GotoInstr::MakeLocationSummary() const {
4088 return new LocationSummary(0, 0, LocationSummary::kNoCall); 4088 return new LocationSummary(0, 0, LocationSummary::kNoCall);
4089 } 4089 }
4090 4090
4091 4091
4092 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 4092 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
4093 // Add deoptimization descriptor for deoptimizing instructions
4094 // that may be inserted before this instruction.
4095 if (!compiler->is_optimizing()) { 4093 if (!compiler->is_optimizing()) {
4094 // Add deoptimization descriptor for deoptimizing instructions that may
4095 // be inserted before this instruction.
4096 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt, 4096 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
4097 GetDeoptId(), 4097 GetDeoptId(),
4098 0); // No token position. 4098 0); // No token position.
4099 } 4099 }
4100 4100
4101 if (HasParallelMove()) { 4101 if (HasParallelMove()) {
4102 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move()); 4102 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
4103 } 4103 }
4104 4104
4105 // We can fall through if the successor is the next block in the list. 4105 // We can fall through if the successor is the next block in the list.
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
4350 PcDescriptors::kOther, 4350 PcDescriptors::kOther,
4351 locs()); 4351 locs());
4352 __ Drop(2); // Discard type arguments and receiver. 4352 __ Drop(2); // Discard type arguments and receiver.
4353 } 4353 }
4354 4354
4355 } // namespace dart 4355 } // namespace dart
4356 4356
4357 #undef __ 4357 #undef __
4358 4358
4359 #endif // defined TARGET_ARCH_X64 4359 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698