Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 15529003: A few simple cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1324 matching lines...) Expand 10 before | Expand all | Expand 10 after
1335 __ CallRuntime(kUpdateFieldCidRuntimeEntry); 1335 __ CallRuntime(kUpdateFieldCidRuntimeEntry);
1336 __ Drop(2); // Drop the field and the value. 1336 __ Drop(2); // Drop the field and the value.
1337 } 1337 }
1338 1338
1339 __ Bind(&ok); 1339 __ Bind(&ok);
1340 } 1340 }
1341 1341
1342 1342
1343 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const { 1343 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const {
1344 const intptr_t kNumInputs = 2; 1344 const intptr_t kNumInputs = 2;
1345 const intptr_t num_temps = 0; 1345 const intptr_t kNumTemps = 0;
1346 LocationSummary* summary = 1346 LocationSummary* summary =
1347 new LocationSummary(kNumInputs, num_temps, LocationSummary::kNoCall); 1347 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
1348 summary->set_in(0, Location::RequiresRegister()); 1348 summary->set_in(0, Location::RequiresRegister());
1349 summary->set_in(1, ShouldEmitStoreBarrier() 1349 summary->set_in(1, ShouldEmitStoreBarrier()
1350 ? Location::WritableRegister() 1350 ? Location::WritableRegister()
1351 : Location::RegisterOrConstant(value())); 1351 : Location::RegisterOrConstant(value()));
1352 return summary; 1352 return summary;
1353 } 1353 }
1354 1354
1355 1355
1356 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1356 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1357 Register instance_reg = locs()->in(0).reg(); 1357 Register instance_reg = locs()->in(0).reg();
(...skipping 1253 matching lines...) Expand 10 before | Expand all | Expand 10 after
2611 } 2611 }
2612 2612
2613 2613
2614 LocationSummary* GotoInstr::MakeLocationSummary() const { 2614 LocationSummary* GotoInstr::MakeLocationSummary() const {
2615 return new LocationSummary(0, 0, LocationSummary::kNoCall); 2615 return new LocationSummary(0, 0, LocationSummary::kNoCall);
2616 } 2616 }
2617 2617
2618 2618
2619 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2619 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2620 __ TraceSimMsg("GotoInstr"); 2620 __ TraceSimMsg("GotoInstr");
2621 // Add deoptimization descriptor for deoptimizing instructions
2622 // that may be inserted before this instruction.
2623 if (!compiler->is_optimizing()) { 2621 if (!compiler->is_optimizing()) {
2622 // Add deoptimization descriptor for deoptimizing instructions that may
2623 // be inserted before this instruction.
2624 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt, 2624 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
2625 GetDeoptId(), 2625 GetDeoptId(),
2626 0); // No token position. 2626 0); // No token position.
2627 } 2627 }
2628 2628
2629 if (HasParallelMove()) { 2629 if (HasParallelMove()) {
2630 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move()); 2630 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
2631 } 2631 }
2632 2632
2633 // We can fall through if the successor is the next block in the list. 2633 // We can fall through if the successor is the next block in the list.
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
2903 compiler->GenerateCall(token_pos(), 2903 compiler->GenerateCall(token_pos(),
2904 &label, 2904 &label,
2905 PcDescriptors::kOther, 2905 PcDescriptors::kOther,
2906 locs()); 2906 locs());
2907 __ Drop(2); // Discard type arguments and receiver. 2907 __ Drop(2); // Discard type arguments and receiver.
2908 } 2908 }
2909 2909
2910 } // namespace dart 2910 } // namespace dart
2911 2911
2912 #endif // defined TARGET_ARCH_MIPS 2912 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698