Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 15529003: A few simple cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1686 matching lines...) Expand 10 before | Expand all | Expand 10 after
1697 __ CallRuntime(kUpdateFieldCidRuntimeEntry); 1697 __ CallRuntime(kUpdateFieldCidRuntimeEntry);
1698 __ Drop(2); // Drop the field and the value. 1698 __ Drop(2); // Drop the field and the value.
1699 } 1699 }
1700 1700
1701 __ Bind(&ok); 1701 __ Bind(&ok);
1702 } 1702 }
1703 1703
1704 1704
1705 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const { 1705 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const {
1706 const intptr_t kNumInputs = 2; 1706 const intptr_t kNumInputs = 2;
1707 const intptr_t num_temps = 0; 1707 const intptr_t kNumTemps = 0;
1708 LocationSummary* summary = 1708 LocationSummary* summary =
1709 new LocationSummary(kNumInputs, num_temps, LocationSummary::kNoCall); 1709 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
1710 summary->set_in(0, Location::RequiresRegister()); 1710 summary->set_in(0, Location::RequiresRegister());
1711 summary->set_in(1, ShouldEmitStoreBarrier() 1711 summary->set_in(1, ShouldEmitStoreBarrier()
1712 ? Location::WritableRegister() 1712 ? Location::WritableRegister()
1713 : Location::RegisterOrConstant(value())); 1713 : Location::RegisterOrConstant(value()));
1714 return summary; 1714 return summary;
1715 } 1715 }
1716 1716
1717 1717
1718 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1718 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1719 Register instance_reg = locs()->in(0).reg(); 1719 Register instance_reg = locs()->in(0).reg();
(...skipping 2563 matching lines...) Expand 10 before | Expand all | Expand 10 after
4283 __ int3(); 4283 __ int3();
4284 } 4284 }
4285 4285
4286 4286
4287 LocationSummary* GotoInstr::MakeLocationSummary() const { 4287 LocationSummary* GotoInstr::MakeLocationSummary() const {
4288 return new LocationSummary(0, 0, LocationSummary::kNoCall); 4288 return new LocationSummary(0, 0, LocationSummary::kNoCall);
4289 } 4289 }
4290 4290
4291 4291
4292 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 4292 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
4293 // Add deoptimization descriptor for deoptimizing instructions
4294 // that may be inserted before this instruction.
4295 if (!compiler->is_optimizing()) { 4293 if (!compiler->is_optimizing()) {
4294 // Add deoptimization descriptor for deoptimizing instructions that may
4295 // be inserted before this instruction.
4296 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt, 4296 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
4297 GetDeoptId(), 4297 GetDeoptId(),
4298 0); // No token position. 4298 0); // No token position.
4299 } 4299 }
4300 4300
4301 if (HasParallelMove()) { 4301 if (HasParallelMove()) {
4302 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move()); 4302 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
4303 } 4303 }
4304 4304
4305 // We can fall through if the successor is the next block in the list. 4305 // We can fall through if the successor is the next block in the list.
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
4707 PcDescriptors::kOther, 4707 PcDescriptors::kOther,
4708 locs()); 4708 locs());
4709 __ Drop(2); // Discard type arguments and receiver. 4709 __ Drop(2); // Discard type arguments and receiver.
4710 } 4710 }
4711 4711
4712 } // namespace dart 4712 } // namespace dart
4713 4713
4714 #undef __ 4714 #undef __
4715 4715
4716 #endif // defined TARGET_ARCH_IA32 4716 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698