Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 15529003: A few simple cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1387 matching lines...) Expand 10 before | Expand all | Expand 10 after
1398 __ CallRuntime(kUpdateFieldCidRuntimeEntry); 1398 __ CallRuntime(kUpdateFieldCidRuntimeEntry);
1399 __ Drop(2); // Drop the field and the value. 1399 __ Drop(2); // Drop the field and the value.
1400 } 1400 }
1401 1401
1402 __ Bind(&ok); 1402 __ Bind(&ok);
1403 } 1403 }
1404 1404
1405 1405
1406 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const { 1406 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const {
1407 const intptr_t kNumInputs = 2; 1407 const intptr_t kNumInputs = 2;
1408 const intptr_t num_temps = 0; 1408 const intptr_t kNumTemps = 0;
1409 LocationSummary* summary = 1409 LocationSummary* summary =
1410 new LocationSummary(kNumInputs, num_temps, LocationSummary::kNoCall); 1410 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
1411 summary->set_in(0, Location::RequiresRegister()); 1411 summary->set_in(0, Location::RequiresRegister());
1412 summary->set_in(1, ShouldEmitStoreBarrier() 1412 summary->set_in(1, ShouldEmitStoreBarrier()
1413 ? Location::WritableRegister() 1413 ? Location::WritableRegister()
1414 : Location::RegisterOrConstant(value())); 1414 : Location::RegisterOrConstant(value()));
1415 return summary; 1415 return summary;
1416 } 1416 }
1417 1417
1418 1418
1419 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1419 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1420 Register instance_reg = locs()->in(0).reg(); 1420 Register instance_reg = locs()->in(0).reg();
(...skipping 1212 matching lines...) Expand 10 before | Expand all | Expand 10 after
2633 __ bkpt(0); 2633 __ bkpt(0);
2634 } 2634 }
2635 2635
2636 2636
2637 LocationSummary* GotoInstr::MakeLocationSummary() const { 2637 LocationSummary* GotoInstr::MakeLocationSummary() const {
2638 return new LocationSummary(0, 0, LocationSummary::kNoCall); 2638 return new LocationSummary(0, 0, LocationSummary::kNoCall);
2639 } 2639 }
2640 2640
2641 2641
2642 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2642 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2643 // Add deoptimization descriptor for deoptimizing instructions
2644 // that may be inserted before this instruction.
2645 if (!compiler->is_optimizing()) { 2643 if (!compiler->is_optimizing()) {
2644 // Add deoptimization descriptor for deoptimizing instructions that may
2645 // be inserted before this instruction.
2646 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt, 2646 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
2647 GetDeoptId(), 2647 GetDeoptId(),
2648 0); // No token position. 2648 0); // No token position.
2649 } 2649 }
2650 2650
2651 if (HasParallelMove()) { 2651 if (HasParallelMove()) {
2652 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move()); 2652 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
2653 } 2653 }
2654 2654
2655 // We can fall through if the successor is the next block in the list. 2655 // We can fall through if the successor is the next block in the list.
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
2872 compiler->GenerateCall(token_pos(), 2872 compiler->GenerateCall(token_pos(),
2873 &label, 2873 &label,
2874 PcDescriptors::kOther, 2874 PcDescriptors::kOther,
2875 locs()); 2875 locs());
2876 __ Drop(2); // Discard type arguments and receiver. 2876 __ Drop(2); // Discard type arguments and receiver.
2877 } 2877 }
2878 2878
2879 } // namespace dart 2879 } // namespace dart
2880 2880
2881 #endif // defined TARGET_ARCH_ARM 2881 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698