Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2717)

Issue 1552863005: replace older/slower/scaler version of conic evalAt (Closed)

Created:
4 years, 11 months ago by reed2
Modified:
4 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -30 lines) Patch
M src/core/SkGeometry.cpp View 3 chunks +11 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552863005/1
4 years, 11 months ago (2016-01-01 20:49:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/f0b6c553aeec0da32193d354a034bd387bdbf19a
4 years, 11 months ago (2016-01-01 21:05:14 UTC) #6
mtklein
It looks like this caused a bunch of tiny little diffs on mobile GPUs: https://gold.skia.org/search2?blame=f0b6c553aeec0da32193d354a034bd387bdbf19a&unt=true&head=true&query=source_type%3Dgm ...
4 years, 11 months ago (2016-01-02 01:30:17 UTC) #8
mtklein
4 years, 11 months ago (2016-01-02 04:53:20 UTC) #9
Message was sent while issue was closed.
On 2016/01/02 01:30:17, mtklein wrote:
> It looks like this caused a bunch of tiny little diffs on mobile GPUs:
>
https://gold.skia.org/search2?blame=f0b6c553aeec0da32193d354a034bd387bdbf19a&...
> 
> It may also be causing the roll to fail, specifically a bunch of GPU-related
> tests on linux_chromium_rel_ng:
> https://codereview.chromium.org/1555883002
> https://codereview.chromium.org/1552113002
> 
> This is the only CL in the roll, so no big rush quite yet.

Third roll looks fine... nevermind.

https://codereview.chromium.org/1558893002/

Powered by Google App Engine
This is Rietveld 408576698