Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issue 1552863004: Linux/CrOS/Cast/Android (and Mac with gn): Build chromium_code with -Wextra. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux/CrOS/Cast/Android (and Mac with gn): Build chromium_code with -Wextra. Lands the -Wextra bits of https://codereview.chromium.org/1551753002/ (reviewed there). Windows, Mac, and iOS already build chromium_code with -Wextra. (Mac and iOS only in the gyp build, not in gn yet.) This makes the other platforms match and also adds -Wextra to chromium_code in gn builds. BUG=573250, 572776 R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://crrev.com/fc84336d83b1e8feb752d7170bdba3f44ff069a4 Cr-Commit-Position: refs/heads/master@{#367256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M build/common.gypi View 4 chunks +5 lines, -7 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552863004/1
4 years, 11 months ago (2015-12-31 22:18:06 UTC) #2
Nico
4 years, 11 months ago (2015-12-31 22:30:47 UTC) #3
Lei Zhang
lgtm
4 years, 11 months ago (2015-12-31 23:04:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/160833)
4 years, 11 months ago (2016-01-01 01:56:25 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-01 03:57:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc84336d83b1e8feb752d7170bdba3f44ff069a4
Cr-Commit-Position: refs/heads/master@{#367256}

Powered by Google App Engine
This is Rietveld 408576698