Remove some dead PDF code.

Remove some dead PDF code.

Committed: https://crrev.com/e2cb8a125d8079f85c16290ee761460cf54b9ec4
Cr-Commit-Position: refs/heads/master@{#367398}

[Lei Zhang, 2015-12-31 19:54:47]

thestig@chromium.org changed reviewers:
+ raymes@chromium.org

[Lei Zhang, 2015-12-31 19:54:48]

Probably left over bits from the in-process to out-of-process conversion.

[raymes, 2016-01-03 23:36:05]

https://codereview.chromium.org/1552833003/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1552833003/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:2694: if (most_visible_page != -1 && !pages_.empty()
&&
Can most_visible_page be -1 anymore?

[Lei Zhang, 2016-01-04 21:57:17]

https://codereview.chromium.org/1552833003/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1552833003/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:2694: if (most_visible_page != -1 && !pages_.empty()
&&
On 2016/01/03 23:36:04, raymes wrote:
> Can most_visible_page be -1 anymore? 

No. I added a DCHECK in its place.

[raymes, 2016-01-04 22:57:33]

lgtm

[Lei Zhang, 2016-01-04 22:58:01]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-01-04 22:58:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552833003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552833003/40001

[commit-bot: I haz the power, 2016-01-04 23:06:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-04 23:08:14]

Description was changed from

==========
Remove some dead PDF code.
==========

to

==========
Remove some dead PDF code.

Committed: https://crrev.com/e2cb8a125d8079f85c16290ee761460cf54b9ec4
Cr-Commit-Position: refs/heads/master@{#367398}
==========

[commit-bot: I haz the power, 2016-01-04 23:08:15]

Patchset 3 (id:??) landed as
https://crrev.com/e2cb8a125d8079f85c16290ee761460cf54b9ec4
Cr-Commit-Position: refs/heads/master@{#367398}

[Lei Zhang, 2016-01-05 17:54:55]

https://codereview.chromium.org/1552833003/diff/40001/pdf/pdfium/pdfium_engin...
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1552833003/diff/40001/pdf/pdfium/pdfium_engin...
pdf/pdfium/pdfium_engine.cc:2692: int most_visible_page = visible_pages_.empty()
? 0 : visible_pages_.front();
But then I look at this again, and I can't remember why I changed this from -1
to 0.

I'm going to revert this for bug 574440, and reland this again.

[Lei Zhang, 2016-01-05 17:55:26]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1557423002/ by thestig@chromium.org.

The reason for reverting is: Causes a crash.

BUG=574440.