Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 155283002: Count consecutive direct adjacent selectors. (Closed)

Created:
6 years, 10 months ago by rune
Modified:
6 years, 10 months ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, ed+blinkwatch_opera.com, darktears
Visibility:
Public.

Description

Count consecutive direct adjacent selectors. The maxDirectAdjacentSelectors counter in RuleFeatureSet should only count the maximum number of consecutive direct adjacent combinators. The number is used to invalidate style for sibling trees. For instance a selector like "div+div div+div" only needs to invalidate a single sibling tree. When a different combinator is encountered, store the number of consecutive direct adjacent combinators seen and reset the counter; instead of counting all direct adjacent combinators in the selector. R=ojan BUG=340866 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
A LayoutTests/fast/css/recalc-direct-adjacent-001.html View 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/recalc-direct-adjacent-001-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
6 years, 10 months ago (2014-02-05 00:07:17 UTC) #1
ojan
lgtm
6 years, 10 months ago (2014-02-05 03:13:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/155283002/1
6 years, 10 months ago (2014-02-05 03:43:39 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 04:21:56 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 10 months ago (2014-02-05 04:21:56 UTC) #5
rune
The CQ bit was checked by rune@opera.com
6 years, 10 months ago (2014-02-05 05:58:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/155283002/1
6 years, 10 months ago (2014-02-05 05:58:44 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 07:30:34 UTC) #8
Message was sent while issue was closed.
Change committed as 166468

Powered by Google App Engine
This is Rietveld 408576698