Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: net/quic/quic_chromium_client_session.cc

Issue 1552783003: Always expect certificates in QuicChromiumClientSession::CanPool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WildcardCert
Patch Set: fix comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_chromium_client_session.cc
diff --git a/net/quic/quic_chromium_client_session.cc b/net/quic/quic_chromium_client_session.cc
index 501732f9899d25af7c2ccdf04774cd5427f8c7c4..87ad4a2ed97364ab0fa6be3f8723ffaef2891b67 100644
--- a/net/quic/quic_chromium_client_session.cc
+++ b/net/quic/quic_chromium_client_session.cc
@@ -566,8 +566,8 @@ bool QuicChromiumClientSession::CanPool(const std::string& hostname,
}
SSLInfo ssl_info;
if (!GetSSLInfo(&ssl_info) || !ssl_info.cert.get()) {
- // We can always pool with insecure QUIC sessions.
- return true;
+ NOTREACHED() << "QUIC should always have certificates.";
+ return false;
}
return SpdySession::CanPool(transport_security_state_, ssl_info,
« no previous file with comments | « no previous file | net/quic/quic_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698