Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4238)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.h

Issue 1552743003: Add chrome.inputMethodPrivate.onImeMenuActivationChanged API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make IME menu test as a separate browser test. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.h
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.h b/chrome/browser/chromeos/input_method/input_method_manager_impl.h
index 92c0d6ab49f5614bff66c2c1d33318f548cc4ea3..bf77997f9f4428167e282f743d5254cda046f8d4 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.h
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.h
@@ -153,9 +153,13 @@ class InputMethodManagerImpl : public InputMethodManager,
void AddObserver(InputMethodManager::Observer* observer) override;
void AddCandidateWindowObserver(
InputMethodManager::CandidateWindowObserver* observer) override;
+ void AddImeMenuObserver(
+ InputMethodManager::ImeMenuObserver* observer) override;
void RemoveObserver(InputMethodManager::Observer* observer) override;
void RemoveCandidateWindowObserver(
InputMethodManager::CandidateWindowObserver* observer) override;
+ void RemoveImeMenuObserver(
+ InputMethodManager::ImeMenuObserver* observer) override;
scoped_ptr<InputMethodDescriptors> GetSupportedInputMethods() const override;
void ActivateInputMethodMenuItem(const std::string& key) override;
bool IsISOLevel5ShiftUsedByCurrentInputMethod() const override;
@@ -174,6 +178,8 @@ class InputMethodManagerImpl : public InputMethodManager,
scoped_refptr<InputMethodManager::State> GetActiveIMEState() override;
void SetState(scoped_refptr<InputMethodManager::State> state) override;
+ void ImeMenuActivationChanged(bool is_active) override;
+
// Sets |candidate_window_controller_|.
void SetCandidateWindowControllerForTesting(
CandidateWindowController* candidate_window_controller);
@@ -240,6 +246,7 @@ class InputMethodManagerImpl : public InputMethodManager,
// A list of objects that monitor the manager.
base::ObserverList<InputMethodManager::Observer> observers_;
base::ObserverList<CandidateWindowObserver> candidate_window_observers_;
+ base::ObserverList<ImeMenuObserver> ime_menu_observers_;
scoped_refptr<StateImpl> state_;

Powered by Google App Engine
This is Rietveld 408576698