Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 1552733002: Convert Pass()→std::move() in //content (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index c5cabc05a076916c54d77dd6ad5223ec859aba2b..26d265ce91e1ebfb4aef31d67df506fca28c0461 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -7,6 +7,7 @@
#include <android/bitmap.h>
#include <android/native_window_jni.h>
#include <stdint.h>
+#include <utility>
#include "base/android/jni_android.h"
#include "base/android/scoped_java_ref.h"
@@ -223,7 +224,7 @@ scoped_ptr<cc::SurfaceIdAllocator> CompositorImpl::CreateSurfaceIdAllocator() {
cc::SurfaceManager* manager = GetSurfaceManager();
DCHECK(manager);
allocator->RegisterSurfaceIdNamespace(manager);
- return allocator.Pass();
+ return allocator;
}
CompositorImpl::CompositorImpl(CompositorClient* client,
@@ -663,11 +664,12 @@ void CompositorImpl::CreateOutputSurface() {
cc::SurfaceManager* manager = GetSurfaceManager();
if (manager) {
- display_client_.reset(new cc::OnscreenDisplayClient(
- real_output_surface.Pass(), manager, HostSharedBitmapManager::current(),
- BrowserGpuMemoryBufferManager::current(),
- host_->settings().renderer_settings,
- base::ThreadTaskRunnerHandle::Get()));
+ display_client_.reset(
+ new cc::OnscreenDisplayClient(std::move(real_output_surface), manager,
+ HostSharedBitmapManager::current(),
+ BrowserGpuMemoryBufferManager::current(),
+ host_->settings().renderer_settings,
+ base::ThreadTaskRunnerHandle::Get()));
scoped_ptr<cc::SurfaceDisplayOutputSurface> surface_output_surface(
new cc::SurfaceDisplayOutputSurface(
manager, surface_id_allocator_.get(), context_provider, nullptr));
@@ -675,9 +677,9 @@ void CompositorImpl::CreateOutputSurface() {
display_client_->set_surface_output_surface(surface_output_surface.get());
surface_output_surface->set_display_client(display_client_.get());
display_client_->display()->Resize(size_);
- host_->SetOutputSurface(surface_output_surface.Pass());
+ host_->SetOutputSurface(std::move(surface_output_surface));
} else {
- host_->SetOutputSurface(real_output_surface.Pass());
+ host_->SetOutputSurface(std::move(real_output_surface));
}
}
@@ -767,7 +769,7 @@ void CompositorImpl::AttachLayerForReadback(scoped_refptr<cc::Layer> layer) {
void CompositorImpl::RequestCopyOfOutputOnRootLayer(
scoped_ptr<cc::CopyOutputRequest> request) {
- root_layer_->RequestCopyOfOutput(request.Pass());
+ root_layer_->RequestCopyOfOutput(std::move(request));
}
void CompositorImpl::OnVSync(base::TimeTicks frame_time,
« no previous file with comments | « content/browser/mojo/service_registry_android.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698