Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp

Issue 1552693002: Add paint testing mode subsequence_caching_disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveSyncPaint
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp b/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp
index e900638d535ebefcf74af5f4c23ea114cbfbd804..63b2c03fe8ddfb273ca2117d7a6614b7a6e1a3f2 100644
--- a/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp
+++ b/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp
@@ -78,10 +78,13 @@ void ContentLayerDelegate::paintContents(
PaintController& paintController = m_graphicsLayer->paintController();
paintController.setDisplayItemConstructionIsDisabled(
paintingControl == WebContentLayerClient::DisplayListConstructionDisabled);
+ paintController.setSubsequenceCachingIsDisabled(
+ paintingControl == WebContentLayerClient::SubsequenceCachingDisabled);
// We also disable caching when Painting or Construction are disabled. In both cases we would like
// to compare assuming the full cost of recording, not the cost of re-using cached content.
- if (paintingControl != WebContentLayerClient::PaintDefaultBehavior)
+ if (paintingControl != WebContentLayerClient::PaintDefaultBehavior
+ && paintingControl != WebContentLayerClient::SubsequenceCachingDisabled)
paintController.invalidateAll();
GraphicsContext::DisabledMode disabledMode = GraphicsContext::NothingDisabled;
@@ -92,6 +95,7 @@ void ContentLayerDelegate::paintContents(
m_graphicsLayer->paint(nullptr, disabledMode);
paintArtifactToWebDisplayItemList(webDisplayItemList, paintController.paintArtifact(), paintableRegion());
paintController.setDisplayItemConstructionIsDisabled(false);
+ paintController.setSubsequenceCachingIsDisabled(false);
}
size_t ContentLayerDelegate::approximateUnsharedMemoryUsage() const

Powered by Google App Engine
This is Rietveld 408576698