Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: content/browser/accessibility/dump_accessibility_browsertest_base.h

Issue 1552683002: Enable DumpAccessibilityTree tests to use cross-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebaseline last Android test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/dump_accessibility_browsertest_base.h
diff --git a/content/browser/accessibility/dump_accessibility_browsertest_base.h b/content/browser/accessibility/dump_accessibility_browsertest_base.h
index 21ae32a1faf94fa21fa3c867aa56f6bf085e1d2f..5e93b9be5626aca5bc1494537a1850612debe595 100644
--- a/content/browser/accessibility/dump_accessibility_browsertest_base.h
+++ b/content/browser/accessibility/dump_accessibility_browsertest_base.h
@@ -31,6 +31,9 @@ class DumpAccessibilityTestBase : public ContentBrowserTest {
void RunTest(const base::FilePath file_path, const char* file_dir);
protected:
+ void SetUpCommandLine(base::CommandLine* command_line) override;
+ void SetUpOnMainThread() override;
+
//
// For subclasses to override:
//
@@ -79,11 +82,12 @@ class DumpAccessibilityTestBase : public ContentBrowserTest {
// until the given string (e.g., "text") appears in the resulting dump.
// A test can make some changes to the document, then append a magic string
// indicating that the test is done, and this framework will wait for that
- // string to appear before comparing the results.
+ // string to appear before comparing the results. There can be multiple
+ // @WAIT-FOR: directives.
void ParseHtmlForExtraDirectives(
const std::string& test_html,
std::vector<AccessibilityTreeFormatter::Filter>* filters,
- std::string* wait_for);
+ std::vector<std::string>* wait_for);
// Create the right AccessibilityTreeFormatter subclass.
AccessibilityTreeFormatter* CreateAccessibilityTreeFormatter();

Powered by Google App Engine
This is Rietveld 408576698