Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552673002: Remove obsolete win_pdf_metafile_for_printing GN flag. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete win_pdf_metafile_for_printing GN flag. Committed: https://crrev.com/f5180a8f93deaaeb1032bf9a89a7f00bdc4c31d7 Cr-Commit-Position: refs/heads/master@{#367364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/config/features.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
4 years, 11 months ago (2015-12-29 19:49:58 UTC) #2
scottmg
lgtm
4 years, 11 months ago (2016-01-04 20:08:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552673002/1
4 years, 11 months ago (2016-01-04 20:27:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 21:06:02 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 21:08:29 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f5180a8f93deaaeb1032bf9a89a7f00bdc4c31d7
Cr-Commit-Position: refs/heads/master@{#367364}

Powered by Google App Engine
This is Rietveld 408576698