Issue 155263: Initialize dragged tab backing store to null....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155263: Initialize dragged tab backing store to null.... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Initialize dragged tab backing store to null. This fixes a crasher I ran into when testing. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20230

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/gtk/tabs/dragged_tab_gtk.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Evan Stade

11 years, 5 months ago (2009-07-09 02:09:51 UTC) #3

On 2009/07/09 01:50:09, Evan Martin wrote:
> why didn't valgrind catch this?
> 
> LGTM

I dunno, are there any tab dragging ui tests?