Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: sync/protocol/sync.proto

Issue 1552623002: [Sync] Add comment that ClientToServerMessage.share can be empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/sync.proto
diff --git a/sync/protocol/sync.proto b/sync/protocol/sync.proto
index f3cbbe58d58f0b11e85ed80ebe8ef5228d666328..f929f730b974d1c7b6dbe7bd5d30178373daa692 100644
--- a/sync/protocol/sync.proto
+++ b/sync/protocol/sync.proto
@@ -730,7 +730,10 @@ message DataTypeContext {
}
message ClientToServerMessage {
+ // |share| field is only used on the server for logging and can sometimes
+ // contain empty string. It should be deprecated.
Nicolas Zea 2015/12/30 20:16:23 Could you mention also what's preventing us from d
pavely 2016/01/04 19:05:17 I've updated comment. We shouldn't actually deprec
required string share = 1;
+
optional int32 protocol_version = 2 [default = 45];
enum Contents {
COMMIT = 1;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698