Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552583002: Remove header files that only have includes. (Closed)

Created:
4 years, 12 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove header files that only have includes. Also do some cleanups in affected files. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d794d34b5deb6ad691c19af758090f9ce46015a3

Patch Set 1 #

Total comments: 8

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : rebase #

Patch Set 5 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -636 lines) Patch
M BUILD.gn View 1 2 3 4 chunks +0 lines, -5 lines 0 comments Download
D core/include/fpdfapi/fpdfapi.h View 1 chunk +0 lines, -16 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 1 chunk +6 lines, -1 line 0 comments Download
D fpdfsdk/include/formfiller/FormFiller.h View 1 chunk +0 lines, -17 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 2 chunks +1 line, -2 lines 0 comments Download
D fpdfsdk/include/fxedit/fxet_stub.h View 1 chunk +0 lines, -16 lines 0 comments Download
D fpdfsdk/include/pdfwindow/IPDFWindow.h View 1 chunk +0 lines, -28 lines 0 comments Download
D fpdfsdk/include/pdfwindow/PDFWindow.h View 1 chunk +0 lines, -17 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CheckBox.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 4 chunks +31 lines, -39 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 2 3 chunks +22 lines, -22 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_PushButton.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_RadioButton.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_ap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 30 chunks +33 lines, -123 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_list.cpp View 7 chunks +4 lines, -18 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_module.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 6 chunks +8 lines, -17 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Button.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Caret.cpp View 4 chunks +2 lines, -8 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 4 chunks +2 lines, -7 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 1 3 chunks +22 lines, -27 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 4 chunks +4 lines, -14 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Icon.cpp View 4 chunks +7 lines, -15 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_IconList.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Label.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 3 chunks +3 lines, -8 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 1 2 3 4 13 chunks +5 lines, -35 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ScrollBar.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Signature.cpp View 3 chunks +2 lines, -30 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 1 2 3 4 4 chunks +38 lines, -64 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 8 chunks +9 lines, -26 lines 0 comments Download
M pdfium.gyp View 1 2 3 4 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-04 19:53:35 UTC) #2
Tom Sepez
https://codereview.chromium.org/1552583002/diff/1/fpdfsdk/include/pdfwindow/PWL_Edit.h File fpdfsdk/include/pdfwindow/PWL_Edit.h (right): https://codereview.chromium.org/1552583002/diff/1/fpdfsdk/include/pdfwindow/PWL_Edit.h#newcode10 fpdfsdk/include/pdfwindow/PWL_Edit.h:10: #include "PWL_EditCtrl.h" nit: full path. https://codereview.chromium.org/1552583002/diff/1/fpdfsdk/include/pdfwindow/PWL_Edit.h#newcode36 fpdfsdk/include/pdfwindow/PWL_Edit.h:36: class CPWL_Edit ...
4 years, 11 months ago (2016-01-04 20:23:12 UTC) #3
Lei Zhang
https://codereview.chromium.org/1552583002/diff/1/fpdfsdk/include/pdfwindow/PWL_Edit.h File fpdfsdk/include/pdfwindow/PWL_Edit.h (right): https://codereview.chromium.org/1552583002/diff/1/fpdfsdk/include/pdfwindow/PWL_Edit.h#newcode10 fpdfsdk/include/pdfwindow/PWL_Edit.h:10: #include "PWL_EditCtrl.h" On 2016/01/04 20:23:12, Tom Sepez wrote: > ...
4 years, 11 months ago (2016-01-05 02:27:09 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/1552583002/diff/40001/fpdfsdk/src/pdfwindow/PWL_Utils.cpp File fpdfsdk/src/pdfwindow/PWL_Utils.cpp (right): https://codereview.chromium.org/1552583002/diff/40001/fpdfsdk/src/pdfwindow/PWL_Utils.cpp#newcode158 fpdfsdk/src/pdfwindow/PWL_Utils.cpp:158: pts[i][j].x *= fWidth; nit: maybe an infix expression ...
4 years, 11 months ago (2016-01-05 17:52:14 UTC) #5
Lei Zhang
https://codereview.chromium.org/1552583002/diff/40001/fpdfsdk/src/pdfwindow/PWL_Utils.cpp File fpdfsdk/src/pdfwindow/PWL_Utils.cpp (right): https://codereview.chromium.org/1552583002/diff/40001/fpdfsdk/src/pdfwindow/PWL_Utils.cpp#newcode158 fpdfsdk/src/pdfwindow/PWL_Utils.cpp:158: pts[i][j].x *= fWidth; On 2016/01/05 17:52:14, Tom Sepez wrote: ...
4 years, 11 months ago (2016-01-06 00:40:34 UTC) #6
Lei Zhang
4 years, 11 months ago (2016-01-06 00:41:08 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
d794d34b5deb6ad691c19af758090f9ce46015a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698