Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1552513003: Revert of Make draw* lines responsible for cache management (Closed)

Created:
4 years, 12 months ago by joshualitt
Modified:
4 years, 12 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext13reallytexutilsdf
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make draw* lines responsible for cache management (patchset #1 id:1 of https://codereview.chromium.org/1521613002/ ) Reason for revert: seeing crashes on android and linux Original issue's description: > Make draw* lines responsible for cache management > > TBR=bsalomon@google.com > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/66957946c0c418e71c0f36bb2904cc38c334eba4 TBR=bsalomon@google.com,jvanverth@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/90e293dae4990a86cb952663ccde8fae55112d7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M include/core/SkPaint.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 10 chunks +44 lines, -17 lines 0 comments Download
M src/gpu/text/GrTextUtils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 5 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
joshualitt
Created Revert of Make draw* lines responsible for cache management
4 years, 12 months ago (2015-12-28 15:14:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552513003/1
4 years, 12 months ago (2015-12-28 15:14:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/90e293dae4990a86cb952663ccde8fae55112d7d
4 years, 12 months ago (2015-12-28 15:14:56 UTC) #4
joshualitt
4 years, 12 months ago (2015-12-28 15:23:43 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1551563003/ by joshualitt@google.com.

The reason for reverting is: might have been premature.

Powered by Google App Engine
This is Rietveld 408576698