PDF: Enable tooltips in Print Preview UI

PDF: Enable tooltips in Print Preview UI

Previously, print preview was unable to access the
chrome.resourcesPrivate API due to cross-origin iframe issues,
preventing tooltips from loading. Following https://crrev.com/367293,
these issues are now resolved and it is possible to access translated
strings in print preview.

BUG=568037
Committed: https://crrev.com/13eab83b614464cb3e98cf7869ff362bf673d61c
Cr-Commit-Position: refs/heads/master@{#368007}

[tsergeant, 2016-01-04 23:50:22]

tsergeant@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2016-01-05 00:01:20]

Unfortunately I might have to revert the change:
https://code.google.com/p/chromium/issues/detail?id=573978

So let's not land this yet :(

On Tue, 5 Jan 2016 at 10:50 <tsergeant@chromium.org> wrote:

> Reviewers: raymes
> CL: https://codereview.chromium.org/1552423002/
>
> Description:
> PDF: Enable tooltips in Print Preview UI
>
> Previously, print preview was unable to access the
> chrome.resourcesPrivate API due to cross-origin iframe issues,
> preventing tooltips from loading. Following https://crrev.com/367293,
> these issues are now resolved and it is possible to access translated
> strings in print preview.
>
> BUG=568037
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -2 lines):
>    M chrome/browser/resources/pdf/pdf.js
>
>
> Index: chrome/browser/resources/pdf/pdf.js
> diff --git a/chrome/browser/resources/pdf/pdf.js
> b/chrome/browser/resources/pdf/pdf.js
> index
>
>
3403bbaf564d594bde328e909bfd08eef7dd23ae..3c5bf9e72aeba85eb3fb0eb4af4e4a92d114e0d3
> 100644
> --- a/chrome/browser/resources/pdf/pdf.js
> +++ b/chrome/browser/resources/pdf/pdf.js
> @@ -262,8 +262,7 @@ function PDFViewer(browserApi) {
>         new ViewportScroller(this.viewport_, this.plugin_, window);
>
>     // Request translated strings.
> -  if (!this.isPrintPreview_)
> -    chrome.resourcesPrivate.getStrings('pdf',
> this.handleStrings_.bind(this));
> +  chrome.resourcesPrivate.getStrings('pdf',
> this.handleStrings_.bind(this));
>   }
>
>   PDFViewer.prototype = {
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[raymes, 2016-01-07 02:30:46]

lgtm

[tsergeant, 2016-01-07 03:00:38]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-01-07 03:03:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552423002/1

[commit-bot: I haz the power, 2016-01-07 03:35:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-07 03:36:41]

Description was changed from

==========
PDF: Enable tooltips in Print Preview UI

Previously, print preview was unable to access the
chrome.resourcesPrivate API due to cross-origin iframe issues,
preventing tooltips from loading. Following https://crrev.com/367293,
these issues are now resolved and it is possible to access translated
strings in print preview.

BUG=568037
==========

to

==========
PDF: Enable tooltips in Print Preview UI

Previously, print preview was unable to access the
chrome.resourcesPrivate API due to cross-origin iframe issues,
preventing tooltips from loading. Following https://crrev.com/367293,
these issues are now resolved and it is possible to access translated
strings in print preview.

BUG=568037

Committed: https://crrev.com/13eab83b614464cb3e98cf7869ff362bf673d61c
Cr-Commit-Position: refs/heads/master@{#368007}
==========

[commit-bot: I haz the power, 2016-01-07 03:36:42]

Patchset 1 (id:??) landed as
https://crrev.com/13eab83b614464cb3e98cf7869ff362bf673d61c
Cr-Commit-Position: refs/heads/master@{#368007}