Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1552333003: Revert of Try using std::call_once (Closed)

Created:
4 years, 11 months ago by mtklein
Modified:
4 years, 11 months ago
Reviewers:
herb_g, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Try using std::call_once (patchset #1 id:1 of https://codereview.chromium.org/1550893002/ ) Reason for revert: Can't use on XP. :( Original issue's description: > Try using std::call_once > > Now that we've got std library support, perhaps we should start using it. > This CL acts as a little canary, and may help fix the linked bug. > > I'm not really sure what's going on in the linked bug, but using > std::call_once over homegrown atomics has to be the right answer... > > BUG=chromium:418041 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1550893002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Going to land this ahead of review while the tree is quiet to see how it rolls. > TBR=herb@google.com > > Committed: https://skia.googlesource.com/skia/+/8895b72f789e5dc8bb99cb9727875439005fc919 TBR=herb@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:418041 Committed: https://skia.googlesource.com/skia/+/e735f163035c4df79024d3bfee8adbe4e4409e1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M src/opts/opts_check_x86.cpp View 3 chunks +29 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Try using std::call_once
4 years, 11 months ago (2016-01-05 02:18:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552333003/1
4 years, 11 months ago (2016-01-05 02:18:44 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 02:18:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e735f163035c4df79024d3bfee8adbe4e4409e1e

Powered by Google App Engine
This is Rietveld 408576698