Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1552313002: Refs #25328 Use a portable shebang (Closed)

Created:
4 years, 11 months ago by mulander
Modified:
4 years, 11 months ago
Reviewers:
ricow1, Bill Hesse
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refs #25328 Use a portable shebang BSD systems don't place bash in /bin and a lot of the dart tools hardcode a #!/bin/bash shebang that fails the 'all' target build (not able to execute dart2js since the interpreter is not found). Solve the issue by using #!/usr/bin/env as the shebang. For scripts that need to pass arguments to bash modify the script to use the set command as the first executed line of shell. BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/634e5a1d02f64cbb0922161433366fde3fd19b4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -29 lines) Patch
M pkg/analysis_server/tool/spec/generate_files View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/generate_files View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tools/bmu_benchmark_gallery.sh View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart2js View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart2js_developer View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart2js_sdk View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer_developer View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer_sdk View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdoc View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartfmt View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartfmt_sdk View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/pub View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/pub_sdk View 1 chunk +1 line, -1 line 0 comments Download
M site/try/create_manifest.sh View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/create_sample_certificates.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/apps/update_homebrew/bin/ssh_with_key View 1 chunk +1 line, -1 line 0 comments Download
M tools/apps/update_homebrew/bin/update_homebrew.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/bots/run_android_tests.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_debian_chroot.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/dartium/download_shellscript_template.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/dartium/start_dartium_roll.sh View 1 chunk +3 lines, -1 line 0 comments Download
M tools/dom/scripts/go.sh View 1 chunk +4 lines, -1 line 0 comments Download
M tools/precompilation/test_linux.sh View 1 chunk +3 lines, -1 line 0 comments Download
M tools/precompilation/test_linux_simarm.sh View 1 chunk +3 lines, -1 line 0 comments Download
M tools/precompilation/test_macos.sh View 1 chunk +3 lines, -1 line 0 comments Download
M tools/presubmit.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/bin/jsshell View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
Bill Hesse
LGTM.
4 years, 11 months ago (2016-01-05 14:05:29 UTC) #2
Bill Hesse
4 years, 11 months ago (2016-01-05 15:26:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
634e5a1d02f64cbb0922161433366fde3fd19b4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698