Issue 155230: Made MediaFilter::host_ and MediaFilter::message_loop_ private.

Issue 155230: Made MediaFilter::host_ and MediaFilter::message_loop_ private. (Closed)

Created:
11 years, 5 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
awong, Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Made MediaFilter::host_ and MediaFilter::message_loop_ private. More cleanup relating to pipeline cleanup. BUG=16008 TEST=no real code chage, nothing should change

Patch Set 1 #

Patch Set 2 : gcc fix #

Patch Set 3 : Merged with git-svn #

Total comments: 1

Patch Set 4 : Merge with ToT #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -75 lines)			Patch
M	chrome/renderer/media/audio_renderer_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/media/buffered_data_source.cc	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	media/base/filters.h	View	1 2	2 chunks	+13 lines, -6 lines	0 comments	Download
M	media/base/mock_media_filters.h	View		7 chunks	+10 lines, -10 lines	0 comments	Download
M	media/base/pipeline_impl.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/audio_renderer_base.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	media/filters/decoder_base.h	View	1	5 chunks	+7 lines, -13 lines	0 comments	Download
M	media/filters/ffmpeg_audio_decoder.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer.cc	View		6 chunks	+10 lines, -10 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/filters/file_data_source.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	media/filters/file_data_source_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/video_renderer_base.cc	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/media/simple_data_source.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

also needed for the next stage in pipeline refactoring

11 years, 5 months ago (2009-07-09 00:24:33 UTC) #2

Alpha Left Google

11 years, 5 months ago (2009-07-09 21:16:50 UTC) #4

LGTM with just one nit.

http://codereview.chromium.org/155230/diff/35/38
File media/base/filters.h (right):

http://codereview.chromium.org/155230/diff/35/38#newcode65
Line 65: virtual void set_host(FilterHost* host) {
If host_ is never changed, can we remove this method and assign host_ in the
constructor? Cause I feel like there's no one else would call set_host in any
filter.

Expand Messages | Collapse Messages