Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1552293002:
Build cygprofile_unittests as part of All on Android. (Closed)
DescriptionBuild cygprofile_unittests as part of All on Android.
There seems to be no existing bot that wants to run the binary built this way.
The target is currently only enabled for 'instrumented' builds, and this change
will make it build in the 'uninstrumented' configuration. With less
instrumentation it is expected to build just fine.
BUG=573326
Committed: https://crrev.com/cf3368493c77dea49a6a76467417ec32416318d4
Cr-Commit-Position: refs/heads/master@{#367500}
Patch Set 1 #
Messages
Total messages: 21 (7 generated)
Description was changed from ========== Build cygprofile_unittests as part of All on Android. There seems to be no existing bot that wants to run the binary built this way. The target is currently only enabled for 'instrumented' builds, and this change will make it build in the 'uninstrumented' configuration. With less instrumentation it is expected to build just fine. BUG=573326 ========== to ========== Build cygprofile_unittests as part of All on Android. There seems to be no existing bot that wants to run the binary built this way. The target is currently only enabled for 'instrumented' builds, and this change will make it build in the 'uninstrumented' configuration. With less instrumentation it is expected to build just fine. BUG=573326 ==========
pasko@chromium.org changed reviewers: + agrieve@chromium.org, dcheng@chromium.org
PTaL the target is small, links in a few seconds at most, I believe
On 2016/01/04 17:15:05, pasko wrote: > PTaL > > the target is small, links in a few seconds at most, I believe lgtm
The CQ bit was checked by pasko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552293002/1
What about GN? =)
On 2016/01/04 19:04:22, dcheng wrote: > What about GN? =) GN bots build all defined targets, so I think it's already being built by GN bots.
On 2016/01/04 19:04:22, dcheng wrote: > What about GN? =) as far as I understand it is there: https://code.google.com/p/chromium/codesearch#chromium/src/BUILD.gn&q=/tools/...
On 2016/01/04 at 19:12:32, pasko wrote: > On 2016/01/04 19:04:22, dcheng wrote: > > What about GN? =) > > as far as I understand it is there: > https://code.google.com/p/chromium/codesearch#chromium/src/BUILD.gn&q=/tools/... OK, thanks.
dcheng: I am going to wait for your formal l-g-t-m ;-)
oh sorry, lgtm
On 2016/01/04 19:18:11, dcheng wrote: > oh sorry, lgtm np, all GYP stuff is scary to me, so I'll attempt to land tomorrow anyway
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by pasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552293002/1
Message was sent while issue was closed.
Description was changed from ========== Build cygprofile_unittests as part of All on Android. There seems to be no existing bot that wants to run the binary built this way. The target is currently only enabled for 'instrumented' builds, and this change will make it build in the 'uninstrumented' configuration. With less instrumentation it is expected to build just fine. BUG=573326 ========== to ========== Build cygprofile_unittests as part of All on Android. There seems to be no existing bot that wants to run the binary built this way. The target is currently only enabled for 'instrumented' builds, and this change will make it build in the 'uninstrumented' configuration. With less instrumentation it is expected to build just fine. BUG=573326 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Build cygprofile_unittests as part of All on Android. There seems to be no existing bot that wants to run the binary built this way. The target is currently only enabled for 'instrumented' builds, and this change will make it build in the 'uninstrumented' configuration. With less instrumentation it is expected to build just fine. BUG=573326 ========== to ========== Build cygprofile_unittests as part of All on Android. There seems to be no existing bot that wants to run the binary built this way. The target is currently only enabled for 'instrumented' builds, and this change will make it build in the 'uninstrumented' configuration. With less instrumentation it is expected to build just fine. BUG=573326 Committed: https://crrev.com/cf3368493c77dea49a6a76467417ec32416318d4 Cr-Commit-Position: refs/heads/master@{#367500} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cf3368493c77dea49a6a76467417ec32416318d4 Cr-Commit-Position: refs/heads/master@{#367500} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
