Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552283002: Return 'correct' size from GrMemoryPool (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/gpu/GrMemoryPool.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrMemoryPool.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1555993005 Patch 1

Messages

Total messages: 13 (8 generated)
joshualitt
The only callers of this are GrTextBlobCache. Because we never free the last block in ...
4 years, 11 months ago (2016-01-04 17:00:14 UTC) #3
bsalomon
lgtm
4 years, 11 months ago (2016-01-04 18:49:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552283002/20001
4 years, 11 months ago (2016-01-05 15:36:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552283002/20001
4 years, 11 months ago (2016-01-05 16:06:44 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 16:07:21 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/22c6f5c731cf7895134e4d78d5d8ad807719877f

Powered by Google App Engine
This is Rietveld 408576698