Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1552233002: [turbofan] Fix turbofan-enabling conditions. (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix turbofan-enabling conditions. This restricts turbofan to turbofan-supported subset for the shipping configuration ("use asm" and features unsupported by Crankshaft). Without this, we compile with Turbofan even when there is try-catch-finally as long as the function is "use asm" or it contains a feature unsupported by crankshaft but supported by turbofan (e.g., 'with' statement). BUG= Committed: https://crrev.com/964964541d1e8d1d396979f20c1e57cf49316606 Cr-Commit-Position: refs/heads/master@{#33085}

Patch Set 1 #

Patch Set 2 : Adjust test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M src/compiler.cc View 1 chunk +22 lines, -5 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please?
4 years, 11 months ago (2016-01-04 14:03:54 UTC) #2
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-04 14:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552233002/20001
4 years, 11 months ago (2016-01-04 14:11:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 14:52:37 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 14:53:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/964964541d1e8d1d396979f20c1e57cf49316606
Cr-Commit-Position: refs/heads/master@{#33085}

Powered by Google App Engine
This is Rietveld 408576698