Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1552223002: ThrowTypeError should not be constructable, so shouldn't have a prototype. (Closed)

Created:
4 years, 11 months ago by Toon Verwaest
Modified:
4 years, 11 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ThrowTypeError should not be constructable, so shouldn't have a prototype. In addition to ThrowTypeError not being a constructor, it was invalidly set up by simply swapping the map. Swapping the map is insufficient since NewFunction* actually set up the function depending on the used map. BUG=chromium:573858 LOG=n Committed: https://crrev.com/09c41d9bfddb89539c81df01b22bfd4389955519 Cr-Commit-Position: refs/heads/master@{#33082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-573858.js View 1 chunk +16 lines, -0 lines 0 comments Download
M test/mjsunit/strict-mode.js View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 11 months ago (2016-01-04 13:02:05 UTC) #2
Camillo Bruni
lgtm
4 years, 11 months ago (2016-01-04 13:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552223002/1
4 years, 11 months ago (2016-01-04 13:13:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 13:32:25 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 13:33:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09c41d9bfddb89539c81df01b22bfd4389955519
Cr-Commit-Position: refs/heads/master@{#33082}

Powered by Google App Engine
This is Rietveld 408576698