third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1552213002: Implement suspend/resume for IntersectionObserver notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1552213002: Implement suspend/resume for IntersectionObserver notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer

Patch Set: Create IntersectionObserverController on demand Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 4e44017bb31be1e9e973df281a7f24a76292cfb6..8e3966173f04510d92f6e7aa796d111483da55b4 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -3959,8 +3959,8 @@ void FrameView::updateViewportIntersectionsForSubtree(LifeCycleUpdateOption phas

updateViewportIntersectionIfNeeded();

// Notify javascript IntersectionObservers

- if (phases == AllPhases)

- frame().document()->ensureIntersectionObserverController().computeTrackedIntersectionObservations();

+ if (phases == AllPhases && frame().document()->intersectionObserverController())

+ frame().document()->intersectionObserverController()->computeTrackedIntersectionObservations();

// Adjust render throttling for iframes based on visibility

bool shouldNotify = !hadValidIntersection || hadEmptyIntersection != m_viewportIntersection.isEmpty();

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp ('k') | no next file » | no next file with comments »