Implement suspend/resume for IntersectionObserver notifications.

Implement suspend/resume for IntersectionObserver notifications.

R=haraken@chromium.org,ojan@chromium.org,esprehn@chromium.org
BUG=540528
Committed: https://crrev.com/018cac05f242bb39c381091b1f242799bd58cdc2
Cr-Commit-Position: refs/heads/master@{#368814}

[szager1, 2016-01-08 23:54:07]

ping

[szager1, 2016-01-10 17:18:41]

ping

[haraken, 2016-01-11 02:39:37]

How about just making IntersectionObserverController an ActiveDOMObject? Then
IntersectionObserverController can just override ActiveDOMObject::suspend/resume
and do whatever it wants to do when the execution context suspends/resumes.

Then we can remove IntersectionObserver::shouldBeSuspended.

[szager1, 2016-01-12 00:25:17]

On 2016/01/11 02:39:37, haraken wrote:
> How about just making IntersectionObserverController an ActiveDOMObject? Then
> IntersectionObserverController can just override
ActiveDOMObject::suspend/resume
> and do whatever it wants to do when the execution context suspends/resumes.
> 
> Then we can remove IntersectionObserver::shouldBeSuspended.

Done, PTAL.

[haraken, 2016-01-12 00:43:55]

Looks nicer. LGTM.

https://codereview.chromium.org/1552213002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserverController.h
(right):

https://codereview.chromium.org/1552213002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserverController.h:35:
IntersectionObserverController(Document*);

Add explicit.

[szager1, 2016-01-12 01:03:45]

https://codereview.chromium.org/1552213002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserverController.h
(right):

https://codereview.chromium.org/1552213002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserverController.h:35:
IntersectionObserverController(Document*);
On 2016/01/12 00:43:55, haraken wrote:
> 
> Add explicit.

Done.

[szager1, 2016-01-12 01:04:55]

The CQ bit was checked by szager@chromium.org

[szager1, 2016-01-12 01:04:55]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1552213002/#ps60001
(title: "Make constructor explicit")

[commit-bot: I haz the power, 2016-01-12 01:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552213002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552213002/60001

[commit-bot: I haz the power, 2016-01-12 02:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 02:23:48]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[szager1, 2016-01-12 05:54:21]

The CQ bit was checked by szager@chromium.org

[szager1, 2016-01-12 05:54:22]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1552213002/#ps80001
(title: "Create IntersectionObserverController on demand")

[commit-bot: I haz the power, 2016-01-12 05:54:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552213002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552213002/80001

[szager1, 2016-01-12 05:55:02]

PTAL: IntersectionObserverController is now created only as needed.

[szager1, 2016-01-12 05:55:16]

The CQ bit was unchecked by szager@chromium.org

[haraken, 2016-01-12 05:56:30]

LGTM

[szager1, 2016-01-12 05:57:21]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2016-01-12 05:57:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552213002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552213002/80001

[commit-bot: I haz the power, 2016-01-12 07:22:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-12 07:24:45]

Description was changed from

==========
Implement suspend/resume for IntersectionObserver notifications.

R=haraken@chromium.org,ojan@chromium.org,esprehn@chromium.org
BUG=540528
==========

to

==========
Implement suspend/resume for IntersectionObserver notifications.

R=haraken@chromium.org,ojan@chromium.org,esprehn@chromium.org
BUG=540528

Committed: https://crrev.com/018cac05f242bb39c381091b1f242799bd58cdc2
Cr-Commit-Position: refs/heads/master@{#368814}
==========

[commit-bot: I haz the power, 2016-01-12 07:24:46]

Patchset 5 (id:??) landed as
https://crrev.com/018cac05f242bb39c381091b1f242799bd58cdc2
Cr-Commit-Position: refs/heads/master@{#368814}