Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Issue 1552203003: Change use of LoadLibrary to LoadLibraryA (Closed)

Created:
4 years, 11 months ago by jvanverth1
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change use of LoadLibrary to LoadLibraryA This allows Skia to be built with UNICODE defined. BUG=skia:4735 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552203003 Committed: https://skia.googlesource.com/skia/+/7a897c0f796df0a1c5b4ee5930b29bfed17ad1b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkOSLibrary_win.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
jvanverth1
4 years, 11 months ago (2016-01-04 15:53:22 UTC) #4
robertphillips1
lgtm
4 years, 11 months ago (2016-01-04 15:56:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552203003/1
4 years, 11 months ago (2016-01-04 15:58:41 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 16:14:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7a897c0f796df0a1c5b4ee5930b29bfed17ad1b4

Powered by Google App Engine
This is Rietveld 408576698