Flag and whitelist to allow crxfs api in NaCl

chrome/browser/pepper_permission_util.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/pepper_permission_util.h"
+
+#include <vector>
+
+#include "base/command_line.h"
+#include "base/sha1.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_tokenizer.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/google/google_util.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_set.h"
+#include "chrome/common/extensions/manifest_handlers/shared_module_info.h"
+#include "extensions/common/constants.h"
+
+using extensions::Extension;
+using extensions::Manifest;
+
+namespace chrome {
+
+namespace {
+
+std::string HashHost(const std::string& host) {
+  const std::string id_hash = base::SHA1HashString(host);
+  DCHECK(id_hash.length() == base::kSHA1Length);

[sky, 2013/05/23 21:14:07]

DCHECK_EQ

[victorhsieh, 2013/05/23 21:39:45]

Done.

+  return base::HexEncode(id_hash.c_str(), id_hash.length());
+}
+
+bool HostIsInSet(const std::string& host, const std::set<std::string>& set) {
+  return set.count(host) > 0 || set.count(HashHost(host)) > 0;
+}
+
+}  // namespace
+
+bool IsExtensionOrSharedModuleWhitelisted(
+    Profile* profile,
+    const GURL& url,
+    const std::set<std::string>& whitelist,
+    const char* command_line_switch) {
+  if (!url.is_valid())
+    return false;
+
+  std::string host = url.host();

[sky, 2013/05/23 21:14:07]

nit: const (since you seem to be using const in this file, such as lines 30 and
66).

[victorhsieh, 2013/05/23 21:39:45]

Done.

+  if (url.SchemeIs(extensions::kExtensionScheme) &&
+      HostIsInSet(host, whitelist)) {
+    return true;
+  }
+
+  const Extension* extension = NULL;
+  ExtensionService* extension_service = !profile ? NULL :
+      extensions::ExtensionSystem::Get(profile)->extension_service();
+  if (extension_service) {
+    extension = extension_service->extensions()->
+        GetExtensionOrAppByURL(ExtensionURLInfo(url));
+  }
+
+  // Check the modules that are imported by this extension to see if any of them
+  // is whitelisted.
+  if (extension) {
+    const std::vector<extensions::SharedModuleInfo::ImportInfo>& imports =
+        extensions::SharedModuleInfo::GetImports(extension);
+    std::vector<extensions::SharedModuleInfo::ImportInfo>::const_iterator it;

[sky, 2013/05/23 21:14:07]

nit: move into for loopl

[victorhsieh, 2013/05/23 21:39:45]

Too long.  I wish I can use auto :/

+    for (it = imports.begin(); it != imports.end(); ++it) {
+      const Extension* imported_extension = extension_service->
+          GetExtensionById(it->extension_id, false);
+      if (imported_extension &&
+          extensions::SharedModuleInfo::IsSharedModule(imported_extension) &&
+          HostIsInSet(it->extension_id, whitelist)) {
+        return true;
+      }
+    }
+  }
+
+  const CommandLine& command_line = *CommandLine::ForCurrentProcess();
+  std::string allowed_list =

[sky, 2013/05/23 21:14:07]

nit: const

[victorhsieh, 2013/05/23 21:39:45]

Done.

+      command_line.GetSwitchValueASCII(command_line_switch);
+  if (allowed_list == "*") {
+    // The wildcard allows socket API only for packaged and platform apps.
+    return extension &&
+        (extension->GetType() == Manifest::TYPE_LEGACY_PACKAGED_APP ||
+         extension->GetType() == Manifest::TYPE_PLATFORM_APP);
+  } else if (!allowed_list.empty()) {

[sky, 2013/05/23 21:14:07]

nit: no else (see style guide).

[victorhsieh, 2013/05/23 21:39:45]

Done.

+    base::StringTokenizer t(allowed_list, ",");
+    while (t.GetNext()) {
+      if (t.token() == host)
+        return true;
+    }
+  }
+
+  return false;
+}
+
+}  // namespace chrome