If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

This kills off sk_parallel_for_thread_count(), which was only used to avoid forcing a deadlock in OncePtrTest on multicore machines in singlethreaded mode... a really niche use case.  Instead just don't explicitly force a race.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552093002

Committed: https://skia.googlesource.com/skia/+/279c7864090a7b96c34c3594e38ced35967c673f

[mtklein_C, 2015-12-31 22:20:59]

Description was changed from

==========
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

BUG=skia:
==========

to

==========
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2015-12-31 22:22:22]

Description was changed from

==========
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

This kills off sk_parallel_for_thread_count(), which was a really niche use case
and not terribly important.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2015-12-31 22:23:10]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-31 22:23:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552093002/1

[mtklein, 2015-12-31 22:26:36]

Description was changed from

==========
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

This kills off sk_parallel_for_thread_count(), which was a really niche use case
and not terribly important.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

This kills off sk_parallel_for_thread_count(), which was only used to avoid
forcing a deadlock in OncePtrTest on multicore machines in singlethreaded
mode... a really niche use case.  Instead just don't explicitly force a race.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2015-12-31 22:30:04]

mtklein@chromium.org changed reviewers:
+ herb@google.com
- mtklein@google.com

[commit-bot: I haz the power, 2015-12-31 22:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-31 22:37:44]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-01-04 14:47:37]

lgtm

[mtklein, 2016-01-05 02:56:11]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-01-05 02:56:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552093002/1

[commit-bot: I haz the power, 2016-01-05 03:13:21]

Description was changed from

==========
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

This kills off sk_parallel_for_thread_count(), which was only used to avoid
forcing a deadlock in OncePtrTest on multicore machines in singlethreaded
mode... a really niche use case.  Instead just don't explicitly force a race.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.

Why have two names if we can get away with one?

This kills off sk_parallel_for_thread_count(), which was only used to avoid
forcing a deadlock in OncePtrTest on multicore machines in singlethreaded
mode... a really niche use case.  Instead just don't explicitly force a race.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/279c7864090a7b96c34c3594e38ced35967c673f
==========

[commit-bot: I haz the power, 2016-01-05 03:13:22]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/279c7864090a7b96c34c3594e38ced35967c673f